Update fatfree-core to use the top level vendor namespace F3. Refs #110 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-factory#110. Required following refactoring most of which was automatable: * Add `namespace F3` to all top level files programatically, and amend the namespace of files that already had a namespace to include prefix `F3`. * Replace all relative refs to non F3 classes in the to level with absolute refs. * Amend all absolute refs to F3 class in non top level classes. * Minor touch up to autoloader - use require_once() not require(). * Fix some implicit refs to non prefixed namespaces in Preview::token(). * The sample app and test at /bcosca/fatfree will have to be updated. Already done sucessfully. Will push shortly.
|
@bcosca any infos about this PR and F3 PSR4 compability? |
|
No go until v4 comes around due to backward compatibility. I suggest we open up a different branch for this as a bridge version. |
|
👍. All tests passed, but a branch would be great to get this change some real life testing. I would start using that upstream branch if you created one. Why not create a dev branch? I think it will be hard to merge these changes with other development branches that are running in parallel, since they would be working without namespaces, so may as well start dev branch here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fatfree core to use the top level vendor namespace
F3. Refs #110. Required following refactoring most of which was automatable:namespace F3to all top level files programatically, and amend the namespace of files that already had a namespace to include prefixF3.